Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish describe-* wrappers #1876

Closed
Alexander-Shukaev opened this issue Dec 28, 2018 · 2 comments
Closed

Finish describe-* wrappers #1876

Alexander-Shukaev opened this issue Dec 28, 2018 · 2 comments

Comments

@Alexander-Shukaev
Copy link

@Alexander-Shukaev Alexander-Shukaev commented Dec 28, 2018

At least describe-key and describe-symbol are used frequently enough. Would be nice to have corresponding counsel-describe-*-functions as well to be able to attach other back ends, e.g. helpful-*.

@Alexander-Shukaev
Copy link
Author

@Alexander-Shukaev Alexander-Shukaev commented Dec 28, 2018

(defun counsel-describe-function ()
  "Forward to `describe-function'.

Docstrings need to be rephrased as well. It should rather say that it forwards calls to counsel-describe-*-function, which is if nil (by the way) should fall back to stock describe-*.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 8, 2019

At least describe-key and describe-symbol are used frequently enough

There's counsel-descbinds already.

And counsel-describe-symbol would basically merge counsel-describe-function, counsel-describe-variable, and counsel-describe-face. This would require a better API in ivy than ivy-set-sources. The new API would have to bind the candidate source and the corresponding action somehow, maybe the way helm does it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants