Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiper-mc function doesn't add cursors just saves marks at every location #1879

Closed
JSpenced opened this issue Jan 8, 2019 · 2 comments
Closed

Comments

@JSpenced
Copy link

@JSpenced JSpenced commented Jan 8, 2019

I can't get swiper-mc working properly. It just seems to save marks at every location in the swiper search buffer but adds no cursors. For example the messages below are different searches that I completed with typing swiper-mc are the ones like :
Mark saved where search started [6 times] but cursors are never added.

Is there a way to debug this? I'd love this functionality.

Mark saved where search started [238 times]
mc/edit-lines: Mark a set of lines first
mc/restore-state-from-overlay: Wrong type argument: overlayp, nil
Mark saved where search started [6 times]
Mark set
next-line: End of buffer [3 times]
Mark set
Mark saved where search started [3 times]
mc/edit-lines: Mark a set of lines first
@JSpenced
Copy link
Author

@JSpenced JSpenced commented Jan 8, 2019

Nevermind #856 is a similar issue!

Just accidentally swiper-mc got added into the mc/commands-to-run-all so it wasn't working properly.

If you move over the command to, mc/commands-to-run-once it solved the issue.

Maybe it should be stated in the doc string of the function that this needs to be in mc/commands-to-run-once or it won't work properly.

@JSpenced JSpenced closed this Jan 8, 2019
abo-abo added a commit that referenced this issue Feb 6, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Feb 6, 2019

Thanks, I've updated the docstring.

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants