highlight bug?

[jagrg]

Swiper erased all highlights in the *Package* buffer immediately after pressing M-x swiper. The same happened in the *EMMS playlist* buffer. Any idea?

[abo-abo]

Swiper calls font-lock-ensure (or font-lock-fontify-buffer for older Emacs) to have the
selection candidates highlighted. It should be OK to call these functions for any buffer that has
font-lock-mode on.

I think it's a problem of the corresponding mode if it bugs out after a call to font-lock-ensure.
I could add some workarounds though. What are the values of major-mode for the problematic buffers?

[jagrg]

I wasn't aware that this was the expected behavior. Would it be possible to revert the buffer to normal once the selection has been made?

[abo-abo]

Would it be possible to revert the buffer to normal once the selection has been made?

It's possible not to call font-lock-ensure for problematic major-modes.
I've already added all modes derived from magit-mode to this list.
I just need a list of major-modes which are problematic for you.

Just use M-: (eval-expression) to see what the value of major-mode is.

[jagrg]

One is package-menu-mode and the other is emms-playlist-mode.

[abo-abo]

See if the last commit solves your issue.

[jagrg]

It didn't solve. I replaced the swiper.el file with the most recent one and restarted emacs. Is there something else I need to do?

[abo-abo]

What's your Emacs version? Maybe you could also add a screenshot of the erased highlights in the
package menu.

[jagrg]

Updating via melpa fixed the problem. I'll be replacing Isearch with swiper and see how it goes. Thanks for this!

[abo-abo]

You're welcome. If the same problem comes up for another mode, just reopen this issue.

[jagrg]

I think org-agenda-mode also needs to be fixed.

[abo-abo]

Thanks!