Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command injection in counsel-git-checkout-action #1905

Closed
illikainen opened this issue Jan 28, 2019 · 0 comments
Closed

Command injection in counsel-git-checkout-action #1905

illikainen opened this issue Jan 28, 2019 · 0 comments

Comments

@illikainen
Copy link
Contributor

@illikainen illikainen commented Jan 28, 2019

counsel-git-checkout-action happily executes command substitutes in
git branch names -- e.g.

$ git clone https://github.com/dyntopia/counsel-branch
$ emacs counsel-branch/test
M-x counsel-git-checkout RET RET
/bin/bash: abcd: command not found
error: pathspec 'remotes/origin/' did not match any file(s) known to git.
illikainen added a commit to illikainen/swiper that referenced this issue Jan 28, 2019
Quoting branch names is necessary to avoid executing shell
substitutions.

Fixes abo-abo#1905.
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Quoting branch names is necessary to avoid executing shell
substitutions.

Fixes abo-abo#1905.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant