Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border screen swiper candidates can't be selected #1923

Closed
Ergus opened this issue Feb 4, 2019 · 2 comments
Closed

Border screen swiper candidates can't be selected #1923

Ergus opened this issue Feb 4, 2019 · 2 comments

Comments

@Ergus
Copy link
Contributor

@Ergus Ergus commented Feb 4, 2019

Sorry again, but there is a new issue as a consequence of fixing #1921 . After some hours testing the fix I figured out that there is a new issue when the candidate is in the screen border (first or last line in the screen) and it was not in the visible portion of the buffer when started searching.
When I do C-j (or RET) in that candidate swiper jumps to some random part in the buffer and the echo area shows: "Mark saved where search started."
Trying other candidates (not in the border) it works fine (even if they where not in the initial visible part of the buffer). basically I need to recenter manually. This is exposed now because the candidate before was never in the border.

@abo-abo abo-abo closed this in 686cf5a Feb 5, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Feb 5, 2019

Thanks, please test.

@Ergus
Copy link
Contributor Author

@Ergus Ergus commented Feb 10, 2019

Maybe I forgot to say thanks!!

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants