Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-make-magic-action prevents documentation #1956

Closed
DamienCassou opened this issue Mar 8, 2019 · 1 comment
Closed

ivy-make-magic-action prevents documentation #1956

DamienCassou opened this issue Mar 8, 2019 · 1 comment

Comments

@DamienCassou
Copy link
Contributor

@DamienCassou DamienCassou commented Mar 8, 2019

The new ivy-make-magit-action prevents understanding what is happening because no docstring or even command name is attached to the bindings. I suggest passing at least a docstring and maybe a name to the function:

(define-key map (kbd "`") (ivy-make-magic-action "b" "Reset find-file starting from a bookmark" 'cd-bookmark)

Another solution could be for ivy-make-magic-action to get the docstring and command name automatically by searching a provided keymap for the given key. But this might be a bit too magical.

I can have a look at implementing one of these if you agree.

Nevertheless, I would suggest not abusing this feature because each time you define a command like that, we loose the ability to name files starting with the chosen character.

@abo-abo abo-abo closed this in 4e07e6f Mar 8, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Mar 8, 2019

Fixed, thanks.

we loose the ability to name files starting with the chosen character.

counsel-find-file-map is still exposed to customization by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants