Skip to content

ivy-make-magic-action prevents documentation #1956

@DamienCassou

Description

@DamienCassou

The new ivy-make-magit-action prevents understanding what is happening because no docstring or even command name is attached to the bindings. I suggest passing at least a docstring and maybe a name to the function:

(define-key map (kbd "`") (ivy-make-magic-action "b" "Reset find-file starting from a bookmark" 'cd-bookmark)

Another solution could be for ivy-make-magic-action to get the docstring and command name automatically by searching a provided keymap for the given key. But this might be a bit too magical.

I can have a look at implementing one of these if you agree.

Nevertheless, I would suggest not abusing this feature because each time you define a command like that, we loose the ability to name files starting with the chosen character.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions