Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy: last result becomes partially invisible with non-zero line-spacing #198

Closed
fjl opened this issue Aug 17, 2015 · 3 comments
Closed

ivy: last result becomes partially invisible with non-zero line-spacing #198

fjl opened this issue Aug 17, 2015 · 3 comments

Comments

@fjl
Copy link
Contributor

@fjl fjl commented Aug 17, 2015

The minibuffer sizing doesn't seem to take line-spacing into account.
I use Cocoa emacs and something (not my config) sets line-spacing to 0.1 globally.
However it is set, a non-zero value makes the last minibuffer result partially invisible.
This could also be bug in emacs.

bad-line-space

If I locally set line-spacing to 0 in ivy--minibuffer-setup, it works.

good-line-spacing

This is similar to #161. Maybe window-text-pixel-size could be useful for solving this issue?

@fjl fjl changed the title ivy: last result becomes partially with line-spacing ivy: last result becomes partially invisible with non-zero line-spacing Aug 17, 2015
fjl added a commit to fjl/dotemacs that referenced this issue Aug 17, 2015
@abo-abo abo-abo closed this in 432bc7e Aug 18, 2015
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 18, 2015

Thanks, please check if it's solved.

@fjl
Copy link
Contributor Author

@fjl fjl commented Aug 18, 2015

It does work, but I'd prefer a solution that keeps the line-spacing.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 18, 2015

There isn't a good API for calculating window height pixel-wise, as far as I know. In any case, it should be an automatic Emacs feature to re-size the minibuffer based on the text that's in it. So not much I can do here except set line-spacing to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.