ivy: last result becomes partially invisible with non-zero line-spacing #198

Closed
fjl opened this Issue Aug 17, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@fjl
Contributor

fjl commented Aug 17, 2015

The minibuffer sizing doesn't seem to take line-spacing into account.
I use Cocoa emacs and something (not my config) sets line-spacing to 0.1 globally.
However it is set, a non-zero value makes the last minibuffer result partially invisible.
This could also be bug in emacs.

bad-line-space

If I locally set line-spacing to 0 in ivy--minibuffer-setup, it works.

good-line-spacing

This is similar to #161. Maybe window-text-pixel-size could be useful for solving this issue?

@fjl fjl changed the title from ivy: last result becomes partially with line-spacing to ivy: last result becomes partially invisible with non-zero line-spacing Aug 17, 2015

fjl added a commit to fjl/dotemacs that referenced this issue Aug 17, 2015

@abo-abo abo-abo closed this in 432bc7e Aug 18, 2015

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Aug 18, 2015

Owner

Thanks, please check if it's solved.

Owner

abo-abo commented Aug 18, 2015

Thanks, please check if it's solved.

@fjl

This comment has been minimized.

Show comment
Hide comment
@fjl

fjl Aug 18, 2015

Contributor

It does work, but I'd prefer a solution that keeps the line-spacing.

Contributor

fjl commented Aug 18, 2015

It does work, but I'd prefer a solution that keeps the line-spacing.

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Aug 18, 2015

Owner

There isn't a good API for calculating window height pixel-wise, as far as I know. In any case, it should be an automatic Emacs feature to re-size the minibuffer based on the text that's in it. So not much I can do here except set line-spacing to 0.

Owner

abo-abo commented Aug 18, 2015

There isn't a good API for calculating window height pixel-wise, as far as I know. In any case, it should be an automatic Emacs feature to re-size the minibuffer based on the text that's in it. So not much I can do here except set line-spacing to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment