Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

got problems with swiper-isearch #2014

Closed
pengpengxp opened this issue Apr 11, 2019 · 3 comments
Closed

got problems with swiper-isearch #2014

pengpengxp opened this issue Apr 11, 2019 · 3 comments

Comments

@pengpengxp
Copy link

@pengpengxp pengpengxp commented Apr 11, 2019

  1. swiper-isearch slow when use or regexp:
    for example, I want to search foo and bar both. I input foo|bar. When I type |, sometimes emacs just stuck! While, swiper works good for this.

  2. ivy--regex-ignore-order does not work for swiper-isearch, I add such thing in my config:

(setq ivy-re-builders-alist
      '((ivy-switch-buffer . ivy--regex-ignore-order)
        (swiper-isearch . ivy--regex-ignore-order)
        (t . re-builder-pinyin)))

ignore order does not work .

@pengpengxp pengpengxp changed the title swiper-isearch slow when use or regexp got problems with swiper-isearch Apr 11, 2019
@abo-abo abo-abo closed this in 9c53320 Apr 11, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Apr 11, 2019

Thanks, please test.

@pengpengxp
Copy link
Author

@pengpengxp pengpengxp commented Apr 12, 2019

Thanks.

Problem 1 is solved.

Problem 2 is still there. When I set swiper-isearch to ivy--regex-ignore-order match. It doesn't work.
Even in normal ordered input, it match something that should not belongs to.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Apr 12, 2019

swiper-isearch will not work with ivy--regex-ignore-order. You can re-write swiper-isearch-function if you really want it to work.

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Need this because in that case the empty string is a match, and
`re-search-forward' does not move point. `isearch-forward-regexp' does
something similar.

* ivy-test.el (swiper-isearch): Add test.

Fixes abo-abo#2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants