Skip to content

counsel-company messes up the text when all candidates have same beginnings #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AmaiKinono opened this issue May 19, 2019 · 2 comments
Closed

counsel-company messes up the text when all candidates have same beginnings #2071

AmaiKinono opened this issue May 19, 2019 · 2 comments

Comments

@AmaiKinono
Copy link
Contributor

AmaiKinono commented May 19, 2019 •
edited
Loading

Please see this:
Peek 2019-05-20 02-08
When all the candidates have same beginnings, the common part is completed when calling counsel-company. Then, after pressing RET, the text is messed up.

Maybe related to #2054.

By the way, I would like not have counsel-company complete the common part for me, but didn't figure out how to do it. Could someone tell me how to do this? Thanks!
@abo-abo
Copy link
Owner

abo-abo commented May 20, 2019

Thanks, please test.

@AmaiKinono
Copy link
Contributor Author

It works. Thanks!

astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
@abo-abo @astoff
counsel.el (counsel-company): Don't rely on company-point
53ff302 
When `company--insert-candidate' to complete the common prefix,
neither `company-point' nor `company-prefi' is updated. So we can't
rely on them.

Fixes abo-abo#2071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abo-abo @AmaiKinono