Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong highlighting/fontification of matches in ivy-occur buffer on top of grep-like counsel-* search functions #2073

Closed
Alexander-Shukaev opened this issue May 21, 2019 · 1 comment

Comments

@Alexander-Shukaev
Copy link

@Alexander-Shukaev Alexander-Shukaev commented May 21, 2019

For example, I counsel-git-grep for solarized dark and get:

./.emacs.d/init/init-solarized-theme.el:42:    (when (memq theme '(solarized-dark solarized-light))
./.emacs.d/init/init-solarized-theme.el:71:  (load-theme 'solarized-dark :no-confirm)
./.emacs.d/init/init-solarized-theme.el:82:            (variant (cond ((eq theme 'solarized-dark ) 'dark )

In minibuffer the highlighting/fontification of matches is correct, namely only matches in the content are highlighted/fontified. However, if I do ivy-occur, the highlighting/fontification of matches changes. In particular, the solarized match gets highlighted/fontified on the names of files (just by accident most probably because it's also present there) and not in the actual content anymore, while dark is still correctly highlighted/fontified. From theoretical standpoint, I would have expected highlighting/fontification algorithms to be the same for both minibuffer and ivy-occur buffer, and if it's not the case yet, maybe it's worth considering it if it's not too tricky.

@abo-abo abo-abo closed this in 226171b May 22, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 22, 2019

Thanks, please test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants