Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivy sets org-hide-emphasis-markers globally #2085

Closed
sebastianpoeplau opened this issue May 29, 2019 · 2 comments
Closed

Ivy sets org-hide-emphasis-markers globally #2085

sebastianpoeplau opened this issue May 29, 2019 · 2 comments

Comments

@sebastianpoeplau
Copy link

@sebastianpoeplau sebastianpoeplau commented May 29, 2019

When Ivy displays its help, it sets org-hide-emphasis-markers to t, a feature introduced in commit 6ec1126. In doing so, it changes the appearance of all of the user's org-mode buffers because the variable doesn't become buffer local automatically. May I suggest to use setq-local instead of setq in order to confine the change to the one buffer owned by Ivy?

(One could argue whether the variable should be automatically buffer local, but for now setting it locally seems to be the right thing.)

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented May 29, 2019

Thanks for catching this!

(One could argue whether the variable should be automatically buffer local, but for now setting it locally seems to be the right thing.)

It's a user option intended to be set globally in user configurations, and Emacs packages should strive to not affect user options, so in this case setq-local is the best middle ground.

@sebastianpoeplau
Copy link
Author

@sebastianpoeplau sebastianpoeplau commented May 30, 2019

Thanks for fixing it so quickly!

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants