Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-resume does not display counsel-git-log output correctly #2133

Closed
leungbk opened this issue Jul 13, 2019 · 2 comments
Closed

ivy-resume does not display counsel-git-log output correctly #2133

leungbk opened this issue Jul 13, 2019 · 2 comments

Comments

@leungbk
Copy link
Contributor

@leungbk leungbk commented Jul 13, 2019

After using counsel-git-log and getting some results, attempting to ivy-resume causes the results to be displayed line by line. This seems to be because ivy-resume does not set counsel-async-split-string-re to the desired \ncommit as counsel-git-log does.

Should counsel-async-ignore-re and counsel-async-split-string-re be made into alists keyed by async counsel- commands?

abo-abo added a commit that referenced this issue Jul 16, 2019
* counsel.el (counsel-async-split-string-re): Obsolete.
(counsel-git-log-split-string-re): Obsolete.

Re #2133
abo-abo added a commit that referenced this issue Jul 16, 2019
* counsel.el (counsel-async-ignore-re): Obsolete.

Re #2133
@abo-abo abo-abo closed this in 5f030d5 Jul 16, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 16, 2019

Thanks, please test.

@leungbk
Copy link
Contributor Author

@leungbk leungbk commented Jul 16, 2019

Thanks!

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
* counsel.el (counsel-async-split-string-re): Obsolete.
(counsel-git-log-split-string-re): Obsolete.

Re abo-abo#2133
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
* counsel.el (counsel-async-ignore-re): Obsolete.

Re abo-abo#2133
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants