Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:group' property for many deffaces` not set. #2135

Closed
emacksnotes opened this issue Jul 14, 2019 · 3 comments
Closed

:group' property for many deffaces` not set. #2135

emacksnotes opened this issue Jul 14, 2019 · 3 comments

Comments

@emacksnotes
Copy link

@emacksnotes emacksnotes commented Jul 14, 2019

:group property of many deffaces not defined properly.

When I do M-x customize-group RET ivy-faces RET I see only one face (i.e. Counsel Variable Documentation face)

But doing an M-x occur RET defface RET on ivy.el throws up the following matches

22 matches for "defface" in buffer: ivy.el
     57:(defface ivy-current-match
     64:(defface ivy-minibuffer-match-highlight
     68:(defface ivy-minibuffer-match-face-1
     75:(defface ivy-minibuffer-match-face-2
     82:(defface ivy-minibuffer-match-face-3
     89:(defface ivy-minibuffer-match-face-4
     96:(defface ivy-confirm-face
    100:(defface ivy-match-required-face
    104:(defface ivy-subdir
    108:(defface ivy-org
    112:(defface ivy-modified-buffer
    116:(defface ivy-modified-outside-buffer
    120:(defface ivy-remote
    127:(defface ivy-virtual
    131:(defface ivy-action
    135:(defface ivy-highlight-face
    139:(defface ivy-prompt-match
    143:(defface ivy-separator
    147:(defface ivy-grep-info
    151:(defface ivy-grep-line-number
    155:(defface ivy-completions-annotations
    159:(defface ivy-yanked-word
@skangas
Copy link

@skangas skangas commented Jul 15, 2019

In recent years, the :group attribute is not necessary. From Emacs Lisp Reference Manual:

‘:group GROUP’
Put this customization item in group GROUP. If this keyword is
missing from a customization item, it’ll be placed in the same
group that was last defined (in the current file).

What version of Emacs are you using?

abo-abo added a commit that referenced this issue Jul 16, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 16, 2019

@skangas is correct, there's no need to put a :group for faces in ivy.el. I've added a :group for the other faces.
@emacksnotes Please check that customize-group ivy-faces indeed works by running make plain from this repo.

@emacksnotes
Copy link
Author

@emacksnotes emacksnotes commented Jul 17, 2019

Please check that customize-group ivy-faces indeed works by running make plain from this repo.

Thanks for the fix. It is working. So, closing this issue.

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants