Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper candidate for make-directory if ivy-extra-directories is nil #2139

Closed
iquiw opened this issue Jul 15, 2019 · 2 comments
Closed

Improper candidate for make-directory if ivy-extra-directories is nil #2139

iquiw opened this issue Jul 15, 2019 · 2 comments

Comments

@iquiw
Copy link
Contributor

@iquiw iquiw commented Jul 15, 2019

  1. make plain
  2. Eval (setq ivy-extra-directories nil).
  3. Find file (C-x C-f) a file under non-existent directory (e.g. /tmp/foo/bar)
  4. M-x make-directory.

Then /tmp/foo (not just foo) is listed as the first and default candidate. And selecting it does not create /tmp/foo directory.

@abo-abo abo-abo closed this in 3c6790f Jul 17, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 17, 2019

Thanks, please test.

Loading

@iquiw
Copy link
Contributor Author

@iquiw iquiw commented Jul 17, 2019

I could create /tmp/foo with the above steps. Thank you!!

Loading

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
1. Don't modify (ivy-state-def ivy-last).
2. "C-M-j" with no input should return (ivy-state-def ivy-last).
3. Update the test, since `read-file-name-default' will detect that
the same (eq) string was returned and return "" instead of the file
name.
4. Add a test that `ivy-read' actually returned the file name.

Re abo-abo#1170
Re abo-abo#1719
Fixes abo-abo#2139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants