-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"ivy-immediate-done" returning empty string #2165
Comments
Thanks. Please test and review the commit message for context. |
Thanks for looking. That change always returns the default directory instead of the current input. Using the above example (assuming you are in swiper project), navigate to "swiper/targets" then run |
* ivy-test.el (ivy-read-directory-name): Add test. Fixes #2165
Thanks for testing. I have now added an automated test for this. |
Seems to work now, thanks. |
I've realized this still doesn't work when you remove directories from the path instead of adding them. For example:
|
When selecting a directory, if you removed elements from the default directory (e.g. by pressing DEL) and then used ivy-immediate-done, you were getting back the starting directory instead of the ancestor directory. Fixes abo-abo#2165
…name `read-directory-name' returns "" when the completion function passes it back the DEF argument. This is a highly questionable behavior that some old functions depend on. Looks like it's better to break those old functions, rather than break the more important functions that have no idea why `read-directory-name' returns "". * ivy-test.el (ivy-read-file-name-in-buffer-visiting-file): Now fails. (ivy-read-directory-name): Add test. Fixes abo-abo#2165 Fixes abo-abo#2149 Re abo-abo#1170
* ivy-test.el (ivy-read-directory-name): Add test. Fixes abo-abo#2165
When selecting a directory, if you removed elements from the default directory (e.g. by pressing DEL) and then used ivy-immediate-done, you were getting back the starting directory instead of the ancestor directory. Fixes abo-abo#2165 Fixes abo-abo#2198
emacs -Q -L . -l ivy.el
in "swiper" project directory(ivy-mode t)
(message "dir %s" (read-directory-name "Test: "))
ivy-immediate-done
(i.e.C-M-j
)For me this prints "dir " instead of "dir /whatever/you/picked".
The text was updated successfully, but these errors were encountered: