Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting with cursor up/down keys from actions #2176

Closed
codecoll opened this issue Jul 30, 2019 · 5 comments
Closed

Selecting with cursor up/down keys from actions #2176

codecoll opened this issue Jul 30, 2019 · 5 comments

Comments

@codecoll
Copy link

@codecoll codecoll commented Jul 30, 2019

I'm testing ivy/counsel after using Helm for a long time and one of my issues is that I can't use the cursor keys to select from the actions list like in Helm.

Yes, the actions have associated keys, but if I don't use a particular action list too often then I don't know the relevant keys, so I have to look for that key on the keyboard, though my fingers are already near the cursor keys, so it would be very convenient to simply select from the list with the cursor keys and enter.

Could we also have cursor key and enter selection in the actions list, besides the current method of pressing a particular key? Thanks.

@codecoll
Copy link
Author

@codecoll codecoll commented Jul 30, 2019

Others also have this problem and think it's one of the things which helm does better:

https://www.reddit.com/r/emacs/comments/5txzfd/is_it_just_me_or_is_counselivy_way_way_better/ddq05rb/

It would be great if the helm way could also be incorporated into ivy, beside the current one.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 31, 2019

Thanks. Please test.

@codecoll
Copy link
Author

@codecoll codecoll commented Jul 31, 2019

I upgraded ivy, restarted emacs, tried counsel-M-x, pressed M-o for the actions list, pressed cursor down and it threw this error:

ivy-read-action-by-key: Wrong type argument: characterp, down

So it's the same as before. Cursor keys cannot be used for selection in the action list.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 31, 2019

You need to set this variable:

(setq ivy-read-action-function 'ivy-read-action-ivy)

@codecoll
Copy link
Author

@codecoll codecoll commented Jul 31, 2019

Ah, yes. It's working well with that. Thanks for the quick implementation.

astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants