Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel-rg adds leading ./ to results #2180

Closed
ambihelical opened this issue Aug 2, 2019 · 2 comments
Closed

counsel-rg adds leading ./ to results #2180

ambihelical opened this issue Aug 2, 2019 · 2 comments

Comments

@ambihelical
Copy link
Contributor

@ambihelical ambihelical commented Aug 2, 2019

Due to a trailing "." on the default counsel-rg-base-command, the results from counsel-rg have a leading "./". This is different than the output of counsel-ag, and also causes issues with other packages which do not expect relative paths in this format. For example projectile will consider a file with the leading "./" to be different than a file that it has already indexed without that prefix and consequently cache both.

The period was added in #795 as a workaround for windows and an old version of ripgrep. I don't know if it is still needed. Workaround is easy of course, but this smells like something that should be done with special case code for windows if it is still needed there.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 2, 2019

Thanks, please test.

@ambihelical
Copy link
Contributor Author

@ambihelical ambihelical commented Aug 2, 2019

Works fine under Ubuntu, someone else will have to test Windows, I don't use it.

astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants