Skip to content

counsel-find-file does not obey file-name-at-point-functions #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
clemera opened this issue Aug 2, 2019 · 2 comments
Closed

counsel-find-file does not obey file-name-at-point-functions #2181

clemera opened this issue Aug 2, 2019 · 2 comments

Comments

@clemera
Copy link
Contributor

clemera commented Aug 2, 2019 •
edited
Loading

Hi,

When pressing M-n in normal find-file the suggested candidates include those from file-name-at-point-functions.

I guess this could be added to counsel-find-file by changing how ivy--minibuffer-setup sets minibuffer-default-add-function. Normal find-file uses the items as returned by read-file-name--defaults. If there are no objections I will give it a try and make a PR.

Any additional suggestions or input is welcome!
@abo-abo
Copy link
Owner

abo-abo commented Aug 3, 2019

Please PR. Thanks in advance.

This was referenced Aug 4, 2019
Closed
Closed
@clemera
Copy link
Contributor Author

clemera commented Aug 4, 2019

After reading the code I believe the best place for the change was in ivy-thing-at-point, see the PR. Let me know if anything is missing.

@abo-abo abo-abo closed this as completed in 4fef498 Aug 7, 2019
astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
@clemera @astoff
Use file-name-at-point-functions for file commands
9159a00 
Fixes abo-abo#2181
Fixes abo-abo#2184
Re abo-abo#1446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@abo-abo @clemera