Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please allow counsel-find-file-with-.* tests to run without network access #2187

Closed
sten0 opened this issue Aug 8, 2019 · 6 comments
Closed

Please allow counsel-find-file-with-.* tests to run without network access #2187

sten0 opened this issue Aug 8, 2019 · 6 comments

Comments

@sten0
Copy link
Contributor

@sten0 sten0 commented Aug 8, 2019

Hi!

Thank you for maintaining Ivy, and thank you for this new release :-)

I've had to use ert-skip on the following tests in the Debian package of Ivy/Counsel/Swiper, because network access for building package and for our CI is forbidden: counsel-find-file-with-dollars, counsel-find-file-with-dotfiles, counsel-find-file-with-spaces.

As far as I can tell this could be solved by bundling the tests into the release tarball using a release hook (I think this happens on the github side); this especially seems to makes sense as counsel--setup-test-files hard-codes a specific commit. That branch and its history are fairly small I'm not sure if it necessary to remove .git...this is usually removed from a release tarball, but if these three tests require a git repo than I think there might be an argument to be made about how actual history is more valuable for reproducible builds than a dummy recreated history that would have random commit hashes.

Cheers,
Nicholas

@abo-abo abo-abo closed this in 361cf87 Aug 21, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 21, 2019

Thanks.

@sten0
Copy link
Contributor Author

@sten0 sten0 commented Sep 28, 2019

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Sep 30, 2019

Sure. Ask your question :)

@sten0
Copy link
Contributor Author

@sten0 sten0 commented Oct 5, 2019

@sten0
Copy link
Contributor Author

@sten0 sten0 commented Oct 5, 2019

A slightly longer explanation of the problem and fix: https://wiki.debian.org/qa.debian.org/gfdlinvariant

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 7, 2019

Are jquery, bootstrap, and the theme from https://github.com/fniessen/org-html-themes all the web things that are needed? (the copy I build must function offline)

Yes.

Do you export or publish directly from the org file, or generate the HTML docs from the texinfo (which has been generated from the org file)?

I export like this:

cd swiper
git clone -b gh-pages https://github.com/abo-abo/swiper gh-pages
cd gh-pages
make index.html

Also, would it be possible to change the documentation license? I didn't ask before, because I
assumed you wouldn't want to. In a nutshell the GFDL front and back cover invariant sections block
inclusion into the Debian archive; at this point in time I'm working on the package for inclusion
into the "non-free" section, but many users do not enable this section. For the documentation to
be available to all users, one of the following changes is needed: The most desirable option from
a Debian perspective is GPL-3+, but GFDL-NIV-1.3+ works too. To make it NIV (no invariants), the
restriction on front and back texts must be dropped, along with any other invariant sections.

OK, I copied the "Good license" variant.

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants