Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel--py-action: make insertion of trailing parens optional, or remove it altogether #2229

Closed
igorhub opened this issue Sep 7, 2019 · 2 comments

Comments

@igorhub
Copy link

@igorhub igorhub commented Sep 7, 2019

After completing a python function, a pair of parens is appended to the end. Most of the time it makes sense, but occasionally it doesn't, forcing the user to remove them by hand.

In my opinion, the benefits of sparing the user two keystrokes (pure muscle memory) in outweighted by the flow-breaking annoyance of having to clean up after wrongful code generation.

The most common case of erroneous parens insertion is, in my experience, completing a function which is passed by value to a higher-order function. Less common one is substituting a similar function that already has a list of arguments.

@abo-abo abo-abo closed this in eed1f06 Oct 11, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 11, 2019

Fixed, thanks. By the way, lately I use Python a lot and never use counsel-jedi. Instead I use completion-at-point after adding lispy-python-completion-at-point to completion-at-point-functions.

@igorhub
Copy link
Author

@igorhub igorhub commented Oct 30, 2019

Thank you for your advice. It never occurred to me that I can use lispy for non-sexp languages such as Python. I think I’ll try it some time in the future.

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants