Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel-find-symbol no longer works #2270

Closed
rgrinberg opened this issue Oct 11, 2019 · 5 comments
Closed

counsel-find-symbol no longer works #2270

rgrinberg opened this issue Oct 11, 2019 · 5 comments

Comments

@rgrinberg
Copy link
Contributor

@rgrinberg rgrinberg commented Oct 11, 2019

I get the following error:

Debugger entered--Lisp error: (no-catch exit nil)
  throw(exit nil)
  exit-minibuffer()
  ivy-exit-with-action(counsel--find-symbol)
  counsel-find-symbol()
  funcall-interactively(counsel-find-symbol)
  call-interactively(counsel-find-symbol nil nil)
  command-execute(counsel-find-symbol)
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 11, 2019

counsel-find-symbol is not supposed to be called from M-x. You should call it via C-. from counsel-describe-function or counsel-describe-variable.

@rgrinberg
Copy link
Contributor Author

@rgrinberg rgrinberg commented Oct 12, 2019

I see. Well I wound why it's interactive then. It seemed like it worked for me before.

@rgrinberg rgrinberg closed this Oct 12, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 12, 2019

It's interactive because it's bound to C-.. You need interactive to bind a function to a key. Unfortunately, there's no way currently to remove it from M-x list.

@rgrinberg
Copy link
Contributor Author

@rgrinberg rgrinberg commented Oct 12, 2019

abo-abo added a commit that referenced this issue Oct 12, 2019
* counsel.el (counsel-M-x): Filter out symbols that have the
  'no-counsel-M-x property.

Fixes #2270
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 12, 2019

Thanks, counsel-find-symbol is now removed from the counsel-M-x list.
It's not removed from execute-extended-command though.

astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
* counsel.el (counsel-M-x): Filter out symbols that have the
  'no-counsel-M-x property.

Fixes abo-abo#2270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants