Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find file / dired try to ping domain name at point by default (and likely hang) #2311

Closed
winny- opened this issue Nov 1, 2019 · 1 comment
Closed

Find file / dired try to ping domain name at point by default (and likely hang) #2311

winny- opened this issue Nov 1, 2019 · 1 comment

Comments

@winny-
Copy link

winny- commented Nov 1, 2019

Tested against

  • GNU Emacs 26.3 with ivy 0.13.0 from elpa.gnu.org
  • GNU Emacs 26.3 with ivy 20191030.1538 from melpa.org

Steps to reproduce

  1. Set up fresh Emacs config (Perhaps: docker run -ti --rm silex/emacs)
  2. M-x package-install RET ivy RET
  3. C-x C-f /tmp/dummy.txt
  4. Type not.existant.com, (note spelling) move point back onto that text.
  5. Ensure C-x C-f and C-x d both work without ivy enabled.
  6. M-x ivy-mode RET
  7. Notice how C-x C-f and C-x d will hang

Possible workaround

Set ffap-machine-known-p to 'reject.

Explanation

It appears ivy will try to complete based off point, which means it will also try to complete machine names (hostnames) by default.

Demo

https://asciinema.org/a/278513
@abo-abo abo-abo closed this as completed in d837871 Nov 3, 2019
@abo-abo
Copy link
Owner

abo-abo commented Nov 3, 2019

Thanks.

astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
@abo-abo @astoff
ivy.el (ivy-thing-at-point): Don't hang when pinging machine
182c514 
Call stack:

- ivy-thing-at-point
- file-name-at-point-functions
- ffap-guess-file-name-at-point
- ffap-guesser
- ffap-machine-at-point
- ffap-machine-p

Fixes abo-abo#2311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abo-abo @winny-