New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minibuffer collapses to one line when resize-mini-windows is true #237

Closed
jnnh opened this Issue Sep 19, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@jnnh
Contributor

jnnh commented Sep 19, 2015

I can reproduce this behaviour with :

Start emacs with emacs -q and evaluate :

(add-to-list 'load-path "your-path-to/swiper")
(require 'swiper)
(setq resize-mini-windows t)

M-x swiper
=> notice that the minibuffer is collapsed to one line.

I am sending a pull request with a possible one-liner solution which fixes it for me.

Thanks for sharing swiper, I love it.

@bnbeckwith

This comment has been minimized.

Show comment
Hide comment
@bnbeckwith

bnbeckwith Sep 22, 2015

The d8d7ed4 commit seems to break emacs in text mode. If I use the latest and run

> emacs -q -nw

Then, my minibuffer is collapsed to one line. That it, it breaks for no-window (terminal) mode. Changing the resize-mini-windows value to t or 'grow-only lets the minibuffer grow in this mode.

The d8d7ed4 commit seems to break emacs in text mode. If I use the latest and run

> emacs -q -nw

Then, my minibuffer is collapsed to one line. That it, it breaks for no-window (terminal) mode. Changing the resize-mini-windows value to t or 'grow-only lets the minibuffer grow in this mode.

@jnnh

This comment has been minimized.

Show comment
Hide comment
@jnnh

jnnh Sep 22, 2015

Contributor

Oops indeed, I can reproduce it in text mode emacs too, thank you for reporting.

This new pull request should fix it in both graphical and text mode. I have tested with resize-mini-windows set to nil, t and grow-only in both graphical and text modes. Hopefully everything is covered. :-)

Contributor

jnnh commented Sep 22, 2015

Oops indeed, I can reproduce it in text mode emacs too, thank you for reporting.

This new pull request should fix it in both graphical and text mode. I have tested with resize-mini-windows set to nil, t and grow-only in both graphical and text modes. Hopefully everything is covered. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment