New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel-git-grep - please add more control #244

Closed
jferguson-gnubio opened this Issue Oct 1, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@jferguson-gnubio

jferguson-gnubio commented Oct 1, 2015

Counsel-git-grep is very nice, but it would be much better if you could edit some of the grep options, perhaps via a hydra?

e.g. you could toggle flags etc., much like with magit (-i, -w etc.)

or define a file match pattern - *.js, *.py etc. - very useful on large mixed language repos

@PythonNut

This comment has been minimized.

Show comment
Hide comment
@PythonNut

PythonNut Oct 1, 2015

Contributor

Would it be okay to just prompt for the command line to run instead of making an interface that necessarily cannot express the full spectrum of options you could choose?

Contributor

PythonNut commented Oct 1, 2015

Would it be okay to just prompt for the command line to run instead of making an interface that necessarily cannot express the full spectrum of options you could choose?

@jferguson-gnubio

This comment has been minimized.

Show comment
Hide comment
@jferguson-gnubio

jferguson-gnubio Oct 1, 2015

That probably would work fine, yes.

jferguson-gnubio commented Oct 1, 2015

That probably would work fine, yes.

@abo-abo abo-abo closed this in c89c167 Oct 2, 2015

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Oct 2, 2015

Owner

Thanks. This is useful for grepping in only certain files.
What I do now, given counsel-git-grep is bound to C-c j: C-u C-c j M-i -- '*.cc' C-m.
Afterwards, this query will be available until Emacs restart.

Owner

abo-abo commented Oct 2, 2015

Thanks. This is useful for grepping in only certain files.
What I do now, given counsel-git-grep is bound to C-c j: C-u C-c j M-i -- '*.cc' C-m.
Afterwards, this query will be available until Emacs restart.

@jferguson-gnubio

This comment has been minimized.

Show comment
Hide comment
@jferguson-gnubio

jferguson-gnubio Oct 2, 2015

That's excellent - thank you. I much appreciate your work. I've just switched to ivy/swiper/counsel from helm after I still found helm awkward and unintuitive at times after 8 months of trying. I'm much preferring your lighter touch.

jferguson-gnubio commented Oct 2, 2015

That's excellent - thank you. I much appreciate your work. I've just switched to ivy/swiper/counsel from helm after I still found helm awkward and unintuitive at times after 8 months of trying. I'm much preferring your lighter touch.

abo-abo added a commit that referenced this issue Oct 19, 2015

Fix the count in user-specified counsel-git-grep
* counsel.el (counsel--gg-count): Generate the count command from
`counsel-git-grep-cmd' by replacing "--full-name" with "-c".

Re #244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment