ivy-resume after swiper goes back to the first result #245

Closed
brabalan opened this Issue Oct 2, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@brabalan

brabalan commented Oct 2, 2015

When I use ivy-resume after a swiper search, the highlighted result is the first one. Is it possible to resume at the same place where swiper was exit?

(To put this in context, I'm trying to understand how to do the same thing than C-s C-s using swiper.)

@abo-abo abo-abo closed this in 3146501 Oct 2, 2015

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Oct 2, 2015

Owner

Thanks.

Owner

abo-abo commented Oct 2, 2015

Thanks.

@brabalan

This comment has been minimized.

Show comment
Hide comment
@brabalan

brabalan Oct 7, 2015

I just realized I did not report that this works great now. Thanks!

brabalan commented Oct 7, 2015

I just realized I did not report that this works great now. Thanks!

@cruegge

This comment has been minimized.

Show comment
Hide comment
@cruegge

cruegge Oct 19, 2015

For some reason, this still does not work for me. It seems as if ivy--preselect-index indeed returns the proper index, but the search still restarts at the top. Minimal example to reproduce the problem is emacs -Q, and then putting

(setf package-load-list '((swiper t))
(package-initialize)
(global-set-key (kbd "C-c s") #'swiper)
(global-set-key (kbd "C-c h") #'ivy-resume)

into the scratch buffer and evaling it.

cruegge commented Oct 19, 2015

For some reason, this still does not work for me. It seems as if ivy--preselect-index indeed returns the proper index, but the search still restarts at the top. Minimal example to reproduce the problem is emacs -Q, and then putting

(setf package-load-list '((swiper t))
(package-initialize)
(global-set-key (kbd "C-c s") #'swiper)
(global-set-key (kbd "C-c h") #'ivy-resume)

into the scratch buffer and evaling it.

abo-abo added a commit that referenced this issue Oct 20, 2015

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Oct 20, 2015

Owner

@cruegge Thanks, should be fixed now.

Owner

abo-abo commented Oct 20, 2015

@cruegge Thanks, should be fixed now.

@cruegge

This comment has been minimized.

Show comment
Hide comment
@cruegge

cruegge Oct 20, 2015

Thanks, works perfectly now.

cruegge commented Oct 20, 2015

Thanks, works perfectly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment