-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swiper/ivy: Make background blending optional #278
Comments
Or alternatively, the blending could just be improved. Maybe it just doesn't work nicely for dark backgrounds right now... |
Exactly, that's an issue I kept running into, until I added blending. Also keep in mind that a program is free to pass propertized strings with custom backgrounds to
This is the direction to go, I think. Which specific theme do you have in mind? In any case, do try Then it's just a matter to patch (defun colir-blend (c1 c2)
"Blend the two colors C1 and C2 using `colir-compose-method'.
C1 and C2 are triples of floats in [0.0 1.0] range."
(apply #'color-rgb-to-hex
(cl-mapcar
colir-compose-method
c1 c2))) Do you know how to make |
Oleh Krehel notifications@github.com writes:
My tsdh-dark-theme.el which ships with emacs. But I think the problem
Oh, yes, that works!
Yes. (frame-parameter nil 'background-mode)
;=> dark The value is either the symbol ,----[ (info "(elisp)Font and Color Parameters") ] Bye, |
Thanks. I've made the change to use |
👍 |
Right now, swiper and ivy blend the background colors of the different match groups with the background color defined for the current selection. With that blending, the background colors I have defined for the groups are hardly recognizable at all:
Would it be possible to make that blending optional so that the match group backgrounds are always taken literally?
Of course, that has one problem. When you have many equal candidates and your input matches the complete candidates, then you can't know what's the currently selected one. In that case, you should define
ivy-current-match
so that it differs from the match group faces in something else than just background, e.g., have it underlined.The text was updated successfully, but these errors were encountered: