New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivy interferes with default tmm-menubar behavior #316

Closed
jonEbird opened this Issue Dec 5, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@jonEbird
Contributor

jonEbird commented Dec 5, 2015

While running without the toolbar or menubar enabled, I will occasionally use tmm-menubar via (M-)` to access the menu items but navigating the menu options is problematic with ivy-mode enabled. To get it to work, I have to clear the text and then use the arrow keys to select the item and repeat for sub-menu items.

I could be missing a configuration but I believe this is a unique issue. I am wondering if a reimplementation of tmm-prompt is in order when using ivy-mode?

abo-abo added a commit that referenced this issue Dec 7, 2015

counsel.el (counsel-tmm): New command
* counsel.el (counsel-tmm-prompt): New defun.
(tmm-km-list): Define this variable here, since `tmm-get-keymap'
modifies a global variable (yuck!).

Re #316

@abo-abo abo-abo closed this in c5661c0 Dec 7, 2015

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Dec 7, 2015

Owner

I am wondering if a reimplementation of tmm-prompt is in order when using ivy-mode?

Added counsel-tmm. I also added a work-around for the original tmm-menubar.

Owner

abo-abo commented Dec 7, 2015

I am wondering if a reimplementation of tmm-prompt is in order when using ivy-mode?

Added counsel-tmm. I also added a work-around for the original tmm-menubar.

@jonEbird

This comment has been minimized.

Show comment
Hide comment
@jonEbird

jonEbird Dec 7, 2015

Contributor

Thanks for the quick workaround fix!

Is there a particular way I should use counsel-tmm? I'm getting (void-variable tmm-table-undef) when calling it interactively.

Update: Likely something on my end as I see that variable being set in tmm.el and yet am getting an error. I also see where you ensure that is was included via your require statement. I'll figure this one out on my one.

Contributor

jonEbird commented Dec 7, 2015

Thanks for the quick workaround fix!

Is there a particular way I should use counsel-tmm? I'm getting (void-variable tmm-table-undef) when calling it interactively.

Update: Likely something on my end as I see that variable being set in tmm.el and yet am getting an error. I also see where you ensure that is was included via your require statement. I'll figure this one out on my one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment