New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could ivy-completing-read pass :caller this-command to ivy-read? #330

Closed
ilohmar opened this Issue Dec 27, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@ilohmar
Contributor

ilohmar commented Dec 27, 2015

I am trying to replace my fine-tuned ido (+ addons) setup with ivy, and in most respects, it's a step forward! One issue I have is this, however: I would like to use ivy-completing-read as a drop-in replacement for as many things as possible, but I still want to set the completion style as per ivy-re-builders-alist for some of these commands.

Are there any downsides to passing :caller this-command where ivy-completing-read calls ivy-read?

This is what I've done to get non-flx completion for org-refile (while I use flx completion everywhere else), and so far that works fine.

@abo-abo abo-abo closed this in 63be079 Dec 27, 2015

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Dec 27, 2015

Owner

Thanks, please test.

Are there any downsides to passing :caller this-command where ivy-completing-read calls ivy-read?

The downside is that it's impossible to tell whether the :caller was explicit of passed via ivy-completing-read. Removes granularity. Also, this-command can be manipulated. Still, I put this-command on priority list of keys behind :caller. So your case should work fine now.

Owner

abo-abo commented Dec 27, 2015

Thanks, please test.

Are there any downsides to passing :caller this-command where ivy-completing-read calls ivy-read?

The downside is that it's impossible to tell whether the :caller was explicit of passed via ivy-completing-read. Removes granularity. Also, this-command can be manipulated. Still, I put this-command on priority list of keys behind :caller. So your case should work fine now.

@ilohmar

This comment has been minimized.

Show comment
Hide comment
@ilohmar

ilohmar Dec 27, 2015

Contributor

Works nicely. Thanks a lot!

Contributor

ilohmar commented Dec 27, 2015

Works nicely. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment