New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues with the new point completion #341

Closed
ghost opened this Issue Jan 8, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@ghost

ghost commented Jan 8, 2016

I upgraded my swiper install and found the new ivy point completion features. I really like the idea, but am running into a couple bugs with this feature, and have disabled it for myself at the moment:

Too aggressive replacement:

I spawn bash shells using shell. When using cd and hitting tab to get completion, ivy will complete the term as well as replace the starting input. This is good for replacing uncompleted content, but not always the whole term used for completion.

Example:

$ cd pat<tab>
$ cd path/to/dir<tab>
$ cd directory/

Expected behavior would be to replace pat in the first, then dir in the second. path/to/dir is replaced in the second, resulting in an invalid directory.


Completion doesn't work from within the minibuffer. I receive a recursive minibuffer error, since ivy handles it in the minibuffer as opposed to the *Completions* buffer.

Example: M-x customize-face def TAB


This is minor, but is there a reason for binding ivy-count-format in 569c11e with the compact value? I usually keep mine disabled, and it is re-enabled for the point completion.

@abo-abo abo-abo closed this in 426cfcb Jan 8, 2016

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Jan 8, 2016

Owner

Thanks, please test. All your concerns have been addressed. Please try to file separate issues for independent concerns.

Owner

abo-abo commented Jan 8, 2016

Thanks, please test. All your concerns have been addressed. Please try to file separate issues for independent concerns.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jan 15, 2016

Thanks for the fixes, I've just now got the opportunity to re-enable and test in my Emacs.

The first two cases work great now, but the ivy-count-format should check empty string rather than nil. I've opened #349 for the special cases needed with empty ivy-count-format in ivy-completion-in-region.

Please try to file separate issues for independent concerns.

Will do in the future.

ghost commented Jan 15, 2016

Thanks for the fixes, I've just now got the opportunity to re-enable and test in my Emacs.

The first two cases work great now, but the ivy-count-format should check empty string rather than nil. I've opened #349 for the special cases needed with empty ivy-count-format in ivy-completion-in-region.

Please try to file separate issues for independent concerns.

Will do in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment