Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put all the faces in the ivy-faces group (and also faces) #389

Closed
hmelman opened this issue Feb 21, 2016 · 1 comment
Closed

Put all the faces in the ivy-faces group (and also faces) #389

hmelman opened this issue Feb 21, 2016 · 1 comment

Comments

@hmelman
Copy link

@hmelman hmelman commented Feb 21, 2016

Because of the line

    (setcdr (assoc load-file-name custom-current-group-alist) 'ivy)

four of the ivy faces are listed in the ivy custom group rather than the ivy-faces group.
This seems wrong to me, shouldn't all the faces be in ivy-faces?
Also, I think the ivy-faces group should also be in the faces group.

So I'd first do the defgroup for ivy, then list all non-face defcustoms
Then define as follows:

    (defgroup ivy-faces nil
      "Faces for `ivy."
      :group ivy
      :group 'faces)

and then list all the deffaces.

@abo-abo abo-abo closed this in ddc1d9f Feb 21, 2016
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Feb 21, 2016

Thanks, it looks like I started doing it to get things more organized, but didn't finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.