New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel--async-sentinel misses errors #394

Closed
hmelman opened this Issue Feb 22, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@hmelman

hmelman commented Feb 22, 2016

I've been working on a counsel-zgrep that looks in the current directory since many things I have don't use git (e.g., the lisp directory of my emacs installation). I was getting very frustrated that some grep strings were working and some weren't, though I knew they matched some files, they just showed no results in ivy..

Following the example in the manual I was using counsel--async-command and I ultimately found the issue in counsel--async-sentinel. It misses any errors other than exit code 1 (and zgrep was exiting with 2).

I think counsel--async-sentinel should catch the other errors and include the exit code in the displayed error message or at least print it with (message) so I would have caught this much sooner.

It would also be nice if there was a way to specify a different sentinel for counsel--async-command.

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Feb 23, 2016

Owner

Thanks, fixed. The API is updated a little as well.

Owner

abo-abo commented Feb 23, 2016

Thanks, fixed. The API is updated a little as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment