counsel-find-file-at-point now requires hitting M-n after C-x C-f

[kaushalmodi]

Hi,

After the recent commit ( 8c7a7fc ), the counsel-find-file-at-point behavior stopped working like before.

Now for the "ffap" feature to work, I need to do C-x C-f followed by M-n. Earlier that M-n step was not required.

I tested it in emacs -Q by just adding the required Melpa installed packages to the load path

(progn
  (add-to-list 'load-path "/home/kmodi/.emacs.d/elpa_25_0/swiper-20160510.2311/")
  (add-to-list 'load-path "/home/kmodi/.emacs.d/elpa_25_0/counsel-20160519.744/")
  (add-to-list 'load-path "/home/kmodi/.emacs.d/elpa_25_0/ivy-20160520.218/")

  (require 'counsel)
  (setq counsel-find-file-at-point t)
  (global-set-key (kbd "C-x C-f") #'counsel-find-file))

Reverting this commit fixes this for me.

So the fix is to add ffap-guesser's output to initial-input instead of to preselect?

[kaushalmodi]

This seems to work but then I do not know the full implications of removing :preselect and ignoring the optional arg initial-input:

(defun counsel-find-file (&optional initial-input)
  "Forward to `find-file'.
When INITIAL-INPUT is non-nil, use it in the minibuffer during completion."
  (interactive)
  (ivy-read "Find file: " 'read-file-name-internal
            :matcher #'counsel--find-file-matcher
            :initial-input (when counsel-find-file-at-point
                             (require 'ffap)
                             (let ((f (ffap-guesser)))
                               (when f (expand-file-name f))))
            :action (lambda (x)
                      (with-ivy-window
                        (find-file (expand-file-name x ivy--directory))))
            :require-match 'confirm-after-completion
            :history 'file-name-history
            :keymap counsel-find-file-map
            :caller 'counsel-find-file))

[abo-abo]

Fixed, thanks.