Weird interaction with ivy-mode and js-mode #528
Comments
I can't reproduce on Emacs 25. What's your Emacs version? |
|
Can you reliably reproduce this bug each time? I recall getting it a few times on extremely slow hardware (shared remote system, huge ping). But I don't remember this happening on any reasonably fast system. |
Interestingly enough I can't reproduce on emacs 24.5.1 running on Ubuntu. |
Thanks for the detailed report. For some reason, I could not reproduce it on my config. But with |
It is working correctly for me now. Thanks for the quick fix. :) |
The fix for this issue removes the prefix on completion: In
I'm not able to reproduce the original issue here, so not sure what a better fix might be. |
The argument passed to `ivy-completion-common-length' looked like: ("js-indent-level" 0 12 (font-lock-face completions-common-part) 12 13 (font-lock-face completions-first-difference)) Note the `font-lock-face' property instead of the `face' property that `ivy-completion-common-length' expected. The function now works with both types. Fixes #528
@thwg, thanks. I'm reverting the previous commit. @bsuh, please test the new fix. |
@abo-abo The new fix is still working correctly for me. |
@abo-abo Ran into another bug now.
|
Example: (setq tab-indent) completes to `tab-always-indent' which has 'completion-common-length property longer than the original string. Re #528
Here's a video of it https://youtu.be/1l9FWjP6ass
The text was updated successfully, but these errors were encountered: