New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-push-view with three or more windows fails #584

Closed
alfaromurillo opened this Issue Jul 13, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@alfaromurillo

alfaromurillo commented Jul 13, 2016

I suppose that this is not implemented yet?

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Jul 14, 2016

It's implemented and works fine for me. Please give a scenario to reproduce the bug.

@alfaromurillo

This comment has been minimized.

alfaromurillo commented Jul 14, 2016

I start emacs with emacs -q

M-: (add-to-list 'load-path "path/to/swiper")
M-: (require 'ivy)
M-x ivy-mode
C-x 3 C-x 3 C-x 3
M-x ivy-push-view
C-x 1
C-x b {

The name of the view is right, it has the three windows, but M-: ivy-views shows only one horz division with two buffers.
My emacs is from about a month ago (c803af7), and swiper is the latest commit (07813be).

Thanks for your help and for this great package!

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Jul 14, 2016

The name of the view is right, it has the three windows, but M-: ivy-views shows only one horz division with two buffers.

Thanks, I see the problem now.

@abo-abo abo-abo closed this in 57c0f5e Jul 14, 2016

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Jul 14, 2016

Please test.

@alfaromurillo

This comment has been minimized.

alfaromurillo commented Jul 14, 2016

Oleh Krehel writes:

Please test.

Thanks it is working now. The only problem is that the size of the
windows is not the same as before. I know that it is not
implemented yet, but maybe you can run balance-windows right after
restoring the view, so that at least they are the same size.

Thanks again,

Jorge.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Jul 15, 2016

I don't have time right now to implement it properly, the window position API is not fully clear to me. Patches welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment