New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance regression in commit e98883f50f5794 #653
Comments
Works fine for me. Here's the profiler result:
Less than 0.01 second is spent on filtering and redisplay after each key press. |
I get
that doesn't sound much, but feels incredibly laggy.
Keep in mind that this only happens when
But that must be wrong, since replacing that |
You mean removing only the require or the whole highlighting statement? Removing the require is, of course, and easy fix. |
I mean this diff: diff --git a/ivy.el b/ivy.el
index e74c0c5..7468e2e 100644
--- a/ivy.el
+++ b/ivy.el
@@ -2695,7 +2695,7 @@ SEPARATOR is used to join the candidates."
str))
(cl-incf i)))))
((and
- (require 'flx nil 'noerror)
+ nil
(or (eq ivy--regex-function 'ivy--regex-fuzzy)
(and (eq ivy--regex-function 'swiper--re-builder)
(let ((caller (ivy-state-caller ivy-last))) Since I don't have |
I also got a huge performance regression, that I assume is the same thing, moving from counsel-20160826.2343 to counsel-20160906.750 from melpa. Sorry I haven't done a proper bisect, but it sounds the same. |
Apologies I'm not particularly proficient at Elisp, profiling etc, but with some experimentation on a variation of the patch hpdeifel suggested, for
I think the culprit might be that I have the |
Please check if it's better now. |
Yes, that's much better.
Thanks!
|
Works nicely - excellent, thank you. |
Thanks for the confirmation. |
Ivy is currently so slow for me that it is barely usable. Typing letters has a noticeable lag.
git bisect
revealed commit e98883f as the culprit.This lag happened in all ivy commands that I tested (
counsel-M-x
,ivy-find-file
and a few others).I can't reproduce it with plain
emacs -Q
, but calling(package-initialize)
with an otherwise empty config suffices to show the bug.Replacing
(require 'flx nil 'noerror)
withnil
inivy--format-minibuffer-line
also makes ivy fast again.The text was updated successfully, but these errors were encountered: