Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-commit-mode isn't a major-mode anymore #692

Closed
tarsius opened this issue Sep 27, 2016 · 1 comment
Closed

git-commit-mode isn't a major-mode anymore #692

tarsius opened this issue Sep 27, 2016 · 1 comment

Comments

@tarsius
Copy link
Contributor

@tarsius tarsius commented Sep 27, 2016

In version two of Magit, git-commit-mode isn't a major-mode anymore. It's now a minor-mode which can be combined with whatever major-mode is most suitable for the commit message format used by a project. The default is text-mode, but something like markdown-mode might also make sense in some cases.

counsel-at-git-issue-p should be adjusted accordingly. (Also there is a typo in the doc-string of that function.)

@tarsius tarsius changed the title git-commit-mode git-commit-mode isn't a major-mode anymore Sep 27, 2016
@abo-abo abo-abo closed this in 89a6830 Sep 28, 2016
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Sep 28, 2016

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants