New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-overlay should require 'overlay.el' #707

Closed
Dickby opened this Issue Oct 14, 2016 · 8 comments

Comments

Projects
None yet
2 participants
@Dickby

Dickby commented Oct 14, 2016

not shure but on my emacs it only works if i require 'overlay'

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Oct 14, 2016

I have no overlay.el on my system. All functions used (overlay-put etc) are C functions.

@Dickby

This comment has been minimized.

Dickby commented Oct 14, 2016

It's not working on my emacs:
GNU Emacs 26.0.50.12

@Dickby

This comment has been minimized.

Dickby commented Oct 14, 2016

if i require overlay it is working for short time and then it gives the error:
ivy--insert-minibuffer: Args out of range: #<buffer scratch>, 0, 1

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Oct 14, 2016

if i require overlay it is working for short time and then it gives the error:
ivy--insert-minibuffer: Args out of range: #, 0, 1

Please provide a reproduction scenario.

Also, what error do you get if you don't (require 'overlay)?

@Dickby

This comment has been minimized.

Dickby commented Oct 14, 2016

i start emacs with -Q
M-x package-initialize
M-x ivy-mode
M-x customize-variable
ivy-display-funktion
set it to overlay
save for session only
M-x

and i get the error message
Wrong type argument: number-or-marker-p, nil

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Oct 14, 2016

You don't need to customize anything, it's all automatic. The overlay function will be used only from ivy-completion-in-region.

@Dickby

This comment has been minimized.

Dickby commented Oct 14, 2016

so how do i enable it to show completion in an overlay?

@Dickby

This comment has been minimized.

Dickby commented Oct 14, 2016

got it thanks.

@Dickby Dickby closed this Oct 14, 2016

abo-abo added a commit that referenced this issue Oct 14, 2016

ivy-overlay.el (ivy-display-function-overlay): Fix up
Don't call `ivy-left-pad' with a negative arg.

This change should theoretically enable you to:

    (setq ivy-display-function 'ivy-display-function-overlay)

Note that this isn't recommended: things go crazy for `swiper' etc.
`'ivy-display-function-overlay' is best used only for in-line
completion (e.g. `complete-symbol').

Fixes #707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment