New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when attempting to use the new ivy complete-symbol functionality #712

Closed
drot opened this Issue Oct 16, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@drot

drot commented Oct 16, 2016

GNU Emacs 25.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.20.9) of 2016-09-17

Started with a blank init file.
Installed ivy.
Enabled ivy-mode.
If I try to use complete-symbol I get the following error:
ivy-display-function-overlay: Invalid function: with-ivy-window

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Oct 16, 2016

Can't reproduce, since I had to (require 'ivy) in order to use ivy-mode. Does that require solve your problem?

@drot

This comment has been minimized.

drot commented Oct 16, 2016

Still no change, tested with the following:

;; Added by Package.el.  This must come before configurations of
;; installed packages.  Don't delete this line.  If you don't want it,
;; just comment it out by adding a semicolon to the start of the line.
;; You may delete these explanatory comments.
(package-initialize)
(require 'ivy)
(ivy-mode 1)

(custom-set-variables
 ;; custom-set-variables was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(package-selected-packages (quote (ivy))))
(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 )
@abo-abo

This comment has been minimized.

Owner

abo-abo commented Oct 16, 2016

Just tried with 25.0.90.1, can't reproduce. Try to reinstall ivy.

In any case, your ivy.el should be loaded. And with-ivy-window is defined there. Just open the file and see what's going on. Might be a byte compilation issue.

@drot

This comment has been minimized.

drot commented Oct 16, 2016

Still happens even with reinstallation. I'm not doing anything special just starting without any init file and installing ivy, full debugger output:

Debugger entered--Lisp error: (invalid-function with-ivy-window)
  with-ivy-window(nil nil "")
  ivy-display-function-overlay(#("\nset-face-bold-p\nset-char-table-parent\nsetenv\nset-terminal-coding-system\nseq-let\nset-language-info-alist\nset-default-toplevel-value\nsetplist\nselect-window" 0 1 (read-only nil) 1 16 (face ((:foreground "black") ivy-current-match) read-only nil) 16 154 (read-only nil)))
  ivy--insert-minibuffer(#("\nset-face-bold-p\nset-char-table-parent\nsetenv\nset-terminal-coding-system\nseq-let\nset-language-info-alist\nset-default-toplevel-value\nsetplist\nselect-window" 0 1 (read-only nil) 1 16 (face ((:foreground "black") ivy-current-match) read-only nil) 16 154 (read-only nil)))
  ivy--exhibit()
  ivy--minibuffer-setup()
  #[0 "\302\303\301\242\"\210\300 \207" [ivy--minibuffer-setup (#0) remove-hook minibuffer-setup-hook] 3]()
  read-from-minibuffer("(se): " nil (keymap keymap (3 keymap (1 . ivy-toggle-ignore) (15 . ivy-occur)) (67108903 . ivy-avy) (33554464 . ivy-restrict-to-matches) (15 . hydra-ivy/body) (22 . ivy-scroll-up-command) (7 . minibuffer-keyboard-quit) (32 . self-insert-command) (18 . ivy-reverse-i-search) (19 . ivy-next-line-or-history) (remap keymap (describe-mode . ivy-help) (kill-ring-save . ivy-kill-ring-save) (kill-line . ivy-kill-line) (end-of-buffer . ivy-end-of-buffer) (beginning-of-buffer . ivy-beginning-of-buffer) (kill-word . ivy-kill-word) (forward-char . ivy-forward-char) (delete-char . ivy-delete-char) (backward-kill-word . ivy-backward-kill-word) (delete-backward-char . ivy-backward-delete-char) (previous-line . ivy-previous-line) (next-line . ivy-next-line)) (9 . ivy-partial-or-done) (10 . ivy-alt-done) (27 keymap (1 . ivy-read-action) (15 . ivy-dispatching-call) (111 . ivy-dispatching-done) (105 . ivy-insert-current) (106 . ivy-yank-word) (114 . ivy-toggle-regexp-quote) (16 . ivy-previous-line-and-call) (14 . ivy-next-line-and-call) (118 . ivy-scroll-down-command) (112 . ivy-previous-history-element) (110 . ivy-next-history-element) (10 . ivy-immediate-done) (13 . ivy-call)) (13 . ivy-done)) nil ivy-history)
  ivy-read("(se): " ("set-face-bold-p" "set-char-table-parent" "setenv" "set-terminal-coding-system" "seq-let" "set-language-info-alist" "set-default-toplevel-value" "setplist" "select-window" "set-window-next-buffers" "set-auto-mode" "set-cursor-color" "set-face-doc-string" "set-transient-map" "sentence-end" "send-string" "set-language-environment-nonascii-translation" "set-process-sentinel" "set-window-combination-limit" "set-frame-font" "setup-cyrillic-environment-map" "set-face-attribute" "seq-reverse" "set-frame-selected-window" "set-face-inverse-video-p" "seq-some" "set-case-syntax-pair" "set-buffer-modified-p" "seq-contains" "seq-drop-while" "set-face-underline-p" "set-category-table" "set-input-mode" "seqp" "secrets-get-alias" "set-right-margin" "set-visited-file-modtime" "set-background-color" "set-fringe-style" "setf" "seconds-to-time" "seq-map" "set-network-process-option" "set-marker-insertion-type" "setq" "seq-max" "seq--pcase-macroexpander" "set-xwidget-query-on-exit-flag" "set-downcase-syntax" "set-input-meta-mode" ...) :predicate fboundp :action ivy-completion-in-region-action :unwind ivy-overlay-cleanup :require-match t :caller ivy-completion-in-region)
  ivy-completion-in-region(#<marker at 305 in .emacs> 307 [ffap-guesser esh-arg dired-view-file shen-mode viper-util ffap-newsgroup-p ox-man debugger-previous-window verilog-mode-indent org-export-org dired-faces gnus-union erc-log wgrep misearch org-archive nnir package-desc-extras slot-boundp ediff-merg nnmail-files gnus-article-highlight cal-html eieio--generic-generalizer horz erc-mode-line-and-header icomplete buffer-or-list dired-find-subdir gnus-score-expire ivy-occur-grep-mode-abbrev-table gnus-position ivy--preselect-index erc-autoaway srecode/expandproto dired-copy-filename-as-kill custom-faces em-script ffap-rfc-directories auth-source-passphrase-alist org-export-pdf mach timezone-make-date-arpa-standard xscheme package-desc-status message-buffers byte-mult ps-print-printer ob-R cl-delete-if ...] fboundp)
  completion-in-region(#<marker at 305 in .emacs> 307 [ffap-guesser esh-arg dired-view-file shen-mode viper-util ffap-newsgroup-p ox-man debugger-previous-window verilog-mode-indent org-export-org dired-faces gnus-union erc-log wgrep misearch org-archive nnir package-desc-extras slot-boundp ediff-merg nnmail-files gnus-article-highlight cal-html eieio--generic-generalizer horz erc-mode-line-and-header icomplete buffer-or-list dired-find-subdir gnus-score-expire ivy-occur-grep-mode-abbrev-table gnus-position ivy--preselect-index erc-autoaway srecode/expandproto dired-copy-filename-as-kill custom-faces em-script ffap-rfc-directories auth-source-passphrase-alist org-export-pdf mach timezone-make-date-arpa-standard xscheme package-desc-status message-buffers byte-mult ps-print-printer ob-R cl-delete-if ...] fboundp)
  completion-at-point()
  funcall-interactively(completion-at-point)
  call-interactively(completion-at-point nil nil)
  command-execute(completion-at-point)
@drot

This comment has been minimized.

drot commented Oct 16, 2016

Well I tried two options and one does work. If I clone the swiper repository and make compile it, then manually add it to the load-path everything works. The issue seems to be with package.el, if I use the new package-install-file function and point it to ivy.el I get the following byte-compilation error:

Compiling file /home/drot/.emacs.d/elpa/ivy-0.8.0/ivy.el at Sun Oct 16 18:23:46 2016
Entering directory ‘/home/drot/.emacs.d/elpa/ivy-0.8.0/’
ivy.el:42:1:Error: Cannot open load file: No such file or directory, ivy-overlay
@Yevgnen

This comment has been minimized.

Contributor

Yevgnen commented Oct 17, 2016

Same error on GNU Emacs 25.1.1 (x86_64-apple-darwin16.0.0, Carbon Version 157 AppKit 1504) of 2016-09-21 with

(require 'package)

(setq package-archives '(("marmalade" . "http://marmalade-repo.org/packages/")
                         ("gnu" . "http://elpa.gnu.org/packages/")
                         ("melpa" . "https://melpa.org/packages/")
                         ("org" . "http://orgmode.org/elpa/")))

(package-initialize)
(setq package-enable-at-startup nil)

(unless (and (file-exists-p (expand-file-name "elpa/archives/marmalade" user-emacs-directory))
             (file-exists-p (expand-file-name "elpa/archives/gnu" user-emacs-directory))
             (file-exists-p (expand-file-name "elpa/archives/melpa" user-emacs-directory))
             (file-exists-p (expand-file-name "elpa/archives/org" user-emacs-directory)))
  (package-refresh-contents))

(unless (package-installed-p 'use-package)
  (package-refresh-contents)
  (package-install 'use-package))
(require 'use-package)

(use-package swiper
  :ensure t
  :bind (("C-s" . swiper)))

@abo-abo abo-abo closed this in 8109655 Oct 17, 2016

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Oct 17, 2016

Please check if this fixes it.

@drot

This comment has been minimized.

drot commented Oct 17, 2016

Fix confirmed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment