-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ivy-read in temporary buffer #717
Comments
Thanks, please test. |
Thanks, it works but actually I was just using For instance, I'm not sure if this would raise some issues, but perhaps
could be replaced with
or simply
? |
The code I used to close this issue is not removed. It was causing too much trouble elsewhere.
This needs to be well-tested. I'll apply this change to my config to check if anything bad happens. If it doesn't, I'll apply this change. |
Sorry about the trouble. I also applied the change locally and tested a few things:
Of course there could be other issues I didn't come across. Please let me know if I can help with testing. PS you surely noticed that the parentheses are not balanced in the code I posted above, it should be:
|
@ericdanan Thanks for helping. I've applied the suggested change. |
You're welcome, hope it won't cause more trouble. |
I have actually found an undesirable (I think) effect of this
and choose eg The solution that seems natural to me is to permanently switch to the buffer from which
I have tested that this works for the same four issues as above : #717 (current issue), #760 , #779 and #810 . But I'm not sure if this could create other issues (perhaps there are situations where one deliberately switches buffer during the candidate selection and wants the action to run in the new buffer?) Incidentally, if I rewrite the above example using
then the same problem occurs but my proposed solution does not work. This is apparently because |
I think it's fine: not perfect, but good enough. The main reason why it's fine is that due to the possibility of Also, the |
OK, thanks for the explanation. |
Sorry to bother you again, but I think the fix you applied in And likewise in But perhaps it makes sense to leave things as they are... |
Please PR if you can, I have too many things on my mind to figure this out. |
Sure, see #1182.
|
It seems that if I call
ivy-read
in a temporary buffer, select a candidate and choose an action, then the action is not executed in the temp buffer but in the buffer from which the temp buffer was created.Example. I am in a buffer where
default-directory
is"dir1"
and evaluate:After I choose a candidate, the message is
dir1
and notdir2
.Is this intended, or if not is there a simple way to make sure the action is run in the buffer in which ivy-read was called?
The text was updated successfully, but these errors were encountered: