New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursor following and recenter after choose in counsel-pt #751

Closed
kimim opened this Issue Nov 2, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@kimim
Contributor

kimim commented Nov 2, 2016

Hi abo-abo,

I want achieve two thing,

  1. is it possible to move the cursor in buffer to the position selected in counsel-pt, as same as in swiper?
  2. how to recenter the buffer when choose the occurance in counsel-pt? When the line is chosen by type Enter, the line of the buffer is not in center, is it possible to recenter it as the way next-error in compile mode do? when (setq next-error-recenter 20), the cursor will always located at line 20.

Thanks.
BRs,
Kimi

@Yevgnen

This comment has been minimized.

Contributor

Yevgnen commented Nov 17, 2016

For 1, do you mean C-M-p and C-M-n ?

@kimim

This comment has been minimized.

Contributor

kimim commented Nov 18, 2016

@Yevgnen Yes! Thanks for your suggestions.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Nov 18, 2016

I don't use counsel-pt so far. But PR to fix it is welcome.

@kimim

This comment has been minimized.

Contributor

kimim commented Nov 25, 2016

@abo-abo PR created for this case. now, when I do ivy-done or ivy-call at counsel-grep, counsel-ag, counsel-pt, the cursor will always in the center of the buffer.
could you help to review my code. Thanks.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Nov 25, 2016

Thanks, I merged the PR with minor changes.

@abo-abo abo-abo closed this Nov 25, 2016

@kimim

This comment has been minimized.

Contributor

kimim commented Nov 25, 2016

I am glad that I can contribute to ivy. Thank you for creating this excellent package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment