/swiper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider ignoring TAGS buffers in swiper-all #787

Closed
Wilfred opened this Issue Nov 23, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Wilfred @abo-abo
@Wilfred
Contributor

Wilfred commented Nov 23, 2016

When I use swiper-all, I often get results from TAGS buffers as well as the buffers I'm editing.

How would you feel about a patch to ignore TAGS buffers? Whilst I understand that swiper-all is supposed to be everything, TAGS file buffers are just an implementation detail and are rarely opened intentionally.
@abo-abo

This comment has been minimized.

Sign in to view
Owner

abo-abo commented Nov 23, 2016

Sounds fine, please send a PR.

Wilfred added a commit to Wilfred/swiper that referenced this issue Nov 25, 2016

@Wilfred
Ignore TAGS buffers in swiper-all 
Factor out the filter logic into a separate function.

Fixes abo-abo#787
1c801a0

@Wilfred Wilfred referenced this issue Nov 25, 2016

Merged

Ignore TAGS buffers in swiper-all #799

@abo-abo abo-abo closed this in #799 Nov 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment