Skip to content

/ swiper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

counsel-rg gets no search results on Windows and result links can't be followed #795

Closed
mwolson opened this issue Nov 25, 2016 · 0 comments
Closed

counsel-rg gets no search results on Windows and result links can't be followed #795

mwolson opened this issue Nov 25, 2016 · 0 comments

Comments

@mwolson
Copy link
Contributor

@mwolson mwolson commented Nov 25, 2016

The default value of counsel-rg-base-command is currently missing the . parameter - without this, rg version 0.3.1 will fail to find any results on Windows.

Further, it is also missing --line-numbers which is necessary to follow links correctly, and there are multiple problems with the C-c C-o command.

An incoming merge request will address all of this.
mwolson pushed a commit to mwolson/swiper that referenced this issue Nov 25, 2016
Michael Olson
Fix abo-abo#795: Address multiple problems with counsel-rg
9c8f601 
* counsel-ag-function: Take base-cmd as a parameter instead of using counsel-ag-base-command
* counsel-rg-base-command: Include line numbers and current directory so it works on Windows
* Make counsel-rg a modified copy of counsel-ag instead of calling it, so we get a working occur buffer
* Update docs to mention counsel-rg
* ivy: Add 'counsel-rg to multiple memq lists that check for 'counsel-ag
@abo-abo abo-abo closed this in 359a6c8 Nov 25, 2016
@ericdanan ericdanan mentioned this issue Sep 3, 2018
Closed
@ambihelical ambihelical mentioned this issue Aug 2, 2019
Closed
abo-abo added a commit that referenced this issue Aug 2, 2019
@abo-abo
counsel.el (counsel-rg-base-command): Don't include directory on non-…
Loading status checks…
327dbd6 
…Windows

Fixes #2180
Re #795
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
@abo-abo @astoff
counsel.el (counsel-rg-base-command): Don't include directory on non-…
6fd1fbe 
…Windows

Fixes abo-abo#2180
Re abo-abo#795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@mwolson
You can’t perform that action at this time.