New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature idea: Merge bookmarks and find-file #813

Closed
justbur opened this Issue Dec 1, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@justbur
Contributor

justbur commented Dec 1, 2016

I don't like to have too many bookmarks so I usually bookmark the directory of the relevant projects I'm working on. This means that I typically use counsel-bookmark then drop into dired and open a file from there. What would make sense to me and I think be a nice feature would be if in another command you could bring up a list of bookmarks but selecting a bookmark that represents a directory would immediately start a find-file session. So it's as if the bookmarks make up a virtual directory that are a starting point for find-file. Does that make sense and what do you think?

@manuel-uberti

This comment has been minimized.

Contributor

manuel-uberti commented Dec 2, 2016

This sounds great to me, as I bookmark directories too.

@justbur

This comment has been minimized.

Contributor

justbur commented Dec 2, 2016

A simple way to do this would just be to have counsel-find-file be the action that applies to directories, but I was thinking it would be interesting to be able to return to the list of bookmarks without exiting ivy as if it is really a directory of symlinks (or something like that).

@joedicastro

This comment has been minimized.

Contributor

joedicastro commented Dec 2, 2016

I think that it would be best to have a separate command to do that, like counsel-grep-or-swiper, thus something like counsel-find-file-or-bookmarks and keep the original counsel-find-file to those that do not to prefer to have both things together. I think that's a good idea, BTW.

Edit: Seems that the first time I read the issue I misinterpreted it, my fault, but after saw the pull request I realize what you really wanted. Still think that's a good idea. 👍

justbur added a commit to justbur/swiper that referenced this issue Dec 5, 2016

counsel.el (counsel-bookmark-avoid-dired): Add
When non-nil and a directory is selected from counsel-bookmark, forward the
choice to counsel-find-file instead of opening a dired buffer.

Fixes abo-abo#813

@abo-abo abo-abo closed this in #816 Dec 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment