Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-20161213.719 font face is wrong. The candidates are invisible. #828

Closed
redguardtoo opened this issue Dec 14, 2016 · 6 comments
Closed

ivy-20161213.719 font face is wrong. The candidates are invisible. #828

redguardtoo opened this issue Dec 14, 2016 · 6 comments

Comments

@redguardtoo
Copy link
Contributor

@redguardtoo redguardtoo commented Dec 14, 2016

Here is the screenshot after M-x counsel-M-x:
emacs-nq8

  • emacs v24.4.1
  • can be reproduced on GUI and console version
  • can be reproduced after I comment out the color-theme setup
@joedicastro
Copy link
Contributor

@joedicastro joedicastro commented Dec 14, 2016

I think this is related with #654 and there is already a pull request to fix it in #827

@redguardtoo
Copy link
Contributor Author

@redguardtoo redguardtoo commented Dec 14, 2016

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Dec 15, 2016

Please check again with the latest master.

@redguardtoo
Copy link
Contributor Author

@redguardtoo redguardtoo commented Dec 15, 2016

It's not fixed in ivy-20161215.543. I think the major issue exists in ivy, because my own command which only use ivy-read has same issue.

@redguardtoo
Copy link
Contributor Author

@redguardtoo redguardtoo commented Dec 16, 2016

(setq ivy-display-style 'fancy) will fix the issue, I'm using Emacs 24.4.1, as mentioned before.

The bad commit is ca84f24, I tested both ca84f24 and HEAD version.

The root cause is below code,

(defun ivy--format-minibuffer-line (str)
  (when (eq ivy-display-style 'fancy)
    (funcall ivy--highlight-function (copy-sequence str))))

I don't understand, if I'm not using fancy style, the function refuse to render minibuffer?

@abo-abo abo-abo closed this in 9151862 Dec 16, 2016
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Dec 16, 2016

Thanks, please test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.