New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evil: Ivy pastes command completion in a current buffer instead of the minibuffer #928

Closed
ogdenwebb opened this Issue Mar 21, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@ogdenwebb

ogdenwebb commented Mar 21, 2017

After the last updates when I'm trying to complete something with default evil-ex(i.e. ":") for example "package-install" after "package-" Ivy pastes completion in current cursor position(8 line) and delete two or thee characters from the first string.
screenshot-2017-03-21_18-19-50

p.s. Counsel-M-x works fine.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Mar 21, 2017

Please post a reproduction scenario. I have no idea how to use evil-ex.

@ogdenwebb

This comment has been minimized.

ogdenwebb commented Mar 21, 2017

Well. The scenario to reproduce:

  1. Install Evil and run evil-mode.
  (require 'evil)
  (evil-mode 1)
  1. Press ":"(i.e. Shift and ; key) to run evil-ex.
  2. Start typing command for completion(for example "package-insta"), press TAB and select "package-install" then hit RET.

@abo-abo abo-abo closed this in ac944ea Mar 21, 2017

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Mar 21, 2017

Thanks, please test

@jenseich

This comment has been minimized.

jenseich commented Apr 26, 2017

An issue remains in the interaction of ivy and evil-ex. After completion, that is step 3 in the reporter's reproduction outline, a newly started ivy command (e.g. counsel-M-x) returns "Wrong type argument: stringp, nil". I don't know enough about debugging emacs and elisp to find the cause, but here's a backtrace, if that could be helpful:

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
evil-ex-update(5 6 0)
read-from-minibuffer("M-x " "^" (keymap (keymap (67108908 . counsel--info-lookup-symbol) (67108910 . counsel-find-symbol)) keymap (3 keymap (19 . ivy-rotate-sort) (1 . ivy-toggle-ignore) (15 . ivy-occur)) (67108903 . ivy-avy) (33554464 . ivy-restrict-to-matches) (15 . hydra-ivy/body) (22 . ivy-scroll-up-command) (7 . minibuffer-keyboard-quit) (32 . self-insert-command) (18 . ivy-reverse-i-search) (19 . ivy-next-line-or-history) (remap keymap (describe-mode . ivy-help) (kill-ring-save . ivy-kill-ring-save) (kill-line . ivy-kill-line) (scroll-down-command . ivy-scroll-down-command) (scroll-up-command . ivy-scroll-up-command) (end-of-buffer . ivy-end-of-buffer) (beginning-of-buffer . ivy-beginning-of-buffer) (kill-word . ivy-kill-word) (forward-char . ivy-forward-char) (delete-char . ivy-delete-char) (backward-kill-word . ivy-backward-kill-word) (backward-delete-char-untabify . ivy-backward-delete-char) (delete-backward-char . ivy-backward-delete-char) (previous-line . ivy-previous-line) (next-line . ivy-next-line)) (9 . ivy-partial-or-done) (10 . ivy-alt-done) (27 keymap (1 . ivy-read-action) (15 . ivy-dispatching-call) (111 . ivy-dispatching-done) (105 . ivy-insert-current) (106 . ivy-yank-word) (114 . ivy-toggle-regexp-quote) (16 . ivy-previous-line-and-call) (14 . ivy-next-line-and-call) (118 . ivy-scroll-down-command) (112 . ivy-previous-history-element) (110 . ivy-next-history-element) (10 . ivy-immediate-done) (13 . ivy-call)) (13 . ivy-done)) nil extended-command-history)
ivy-read("M-x " [content-type-p \ Apply\ and\ Save\ new-fprs highlight-numbers-mode-hook viper-util qp-or-base64 ox-man debugger-previous-window verilog-mode-indent org-export-org custom-comment-hide rfc822-snarf-frob-list method-not-allowed :insert-button-args unexpected nomesg nnir custom-state-buffer-message doc-view-set-slice-using-mouse custom-face-state-set-and-redraw custom-magic-value-create gnus-article-highlight cal-html tweak :custom-level erc-mode-line-and-header custom-browse-group-tag custom-group-visibility message-simplify-subject-functions gnus-score-expire its-part-1 its-part-2 shr-use-fonts apropos-regexp srecode/expandproto addr custom-group-tag-faces em-script custom-unlispify-tag-names makefile-delete-backslash org-export-pdf epg--status-BADARMOR mm-use-ultra-safe-encoding custom-reset-button-menu old-groups Encrypt\ Message cancel-messages ps-print-printer custom-face-get-current-spec message-insert-importance-low ...] :predicate commandp :require-match t :history extended-command-history :action #[257 "\304\305!\203\f�\306\307�!!\210��\307�!\211��\310\307�!\311")\207" [current-prefix-arg prefix-arg this-command real-this-command featurep smex smex-rank intern command-execute record] 4 "\n\n(fn CMD)"] :sort t :keymap (keymap (67108908 . counsel--info-lookup-symbol) (67108910 . counsel-find-symbol)) :initial-input "^" :caller counsel-M-x)
counsel-M-x()
funcall-interactively(counsel-M-x)
call-interactively(counsel-M-x nil nil)
command-execute(counsel-M-x)

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Apr 26, 2017

@jenseich If you have a reproducible scenario, please open a new issue. I'm not an evil guy, try to write down simple steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment