Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel-yank-pop ignores some kill-ring entries #973

Closed
vonkempnz opened this Issue Apr 25, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@vonkempnz
Copy link

vonkempnz commented Apr 25, 2017

I've noticed that counsel-yank-pop seems to not display some entries from the kill-ring. I don't know the exact criteria, but it seems to ignore short entries that contain contain non-ASCII characters.

For example, the following kill-ring entries do not appear in the counsel-yank-pop completion list:

"•"
"×"
"©" 

The entries:

"• "
"× "
"© " 

are similarly ignored. However the entries:

"• abcd"
"× abcd"
"© abcd"

and

"•
×
©"

all appear in the list as expected.

Also, an unrelated question:- if I do an accidental yank-pop (via M-y), Emacs tells me that the "Previous command was not a yank". However, the behaviour of counsel-yank-pop is different, bringing up the completion list regardless of the previous command. Can I change this?

If it matters, I'm running swiper 0.9.0 and mac-port Emacs 25.2.1 on macOS 10.12.4, although I see the same result on GNU NS Emacs.

@vonkempnz

This comment has been minimized.

Copy link
Author

vonkempnz commented Apr 25, 2017

I just tested a bit further and it seems counsel-yank-pop ignores all kill-ring entries less than three characters long. Is this intentional?

@abo-abo

This comment has been minimized.

Copy link
Owner

abo-abo commented Apr 25, 2017

Is this intentional?

Well, it is in the code; I don't remember why I put it there. Probably because it's faster to type out 1-2 chars than to call counsel-yank-pop.

@abo-abo

This comment has been minimized.

Copy link
Owner

abo-abo commented Apr 25, 2017

However, the behaviour of counsel-yank-pop is different, bringing up the completion list regardless of the previous command. Can I change this?

There's no reason to change it. The default restriction is pretty arbitrary and inconvenient. And you can quit counsel-yank-pop with C-g.

@abo-abo abo-abo closed this in f98f89f Apr 25, 2017

@abo-abo

This comment has been minimized.

Copy link
Owner

abo-abo commented Apr 25, 2017

I removed the restriction. I guess it's useful for copying weird Unicode chars and selecting them with C-n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.