New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
! ! ! breaks ivy--exhibit #976
Comments
Thanks, I did some testing to reproduce the bug. (should (equal (ivy--regex-ignore-order "^v f") '(("^v" . t) ("f" . t))))
(should (equal (ivy--regex-ignore-order "^v ! f") '(("^v" . t) ("f"))))
(should (equal (ivy--regex-ignore-order "^v") '(("^v" . t))))
(should (equal (ivy--regex-ignore-order "^v! ") '(("^v" . t)))) The last test fails. Could you look into fixing it (if I remember correctly, some of How it's supposed to work: everything after the last But that means currently that it's impossible to match a literal |
Ha, I bumped into this again today when trying to search for literal !. I'll try to write a PR. How do you feel about using |
That's fine as well. |
This enables ivy--regex-ignore-order users to enter "foo\!" or "foo\ " to match a literal ! or space. ivy--regex-plus attaches a different meaning to spaces, so we do not support this escaping there. It also fixes a crash if the user enters multiple !!!. We now just discard these. Fixes abo-abo#976.
Typing "! ! ! " in the minibuffer with
counsel-M-x
produces:This seems to happen with all counsel commands. Once this error has been triggered, ivy stops filtering results until you
C-g
and try again.I'm using
ivy--regex-ignore-order
inivy-re-builders-alist
.The text was updated successfully, but these errors were encountered: