Prevent opening an already open file in counsel-grep #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* counsel.el (counsel-grep-action): If a file is already open in a buffer, get that buffer's handle using get-file-buffer. This is to prevent the scenario where a file is already opened using find-file-literally. In that case, if find-file is attempted for the same file, user is nagged with question if they intended to switch to opening the file normally from "literally". Situation escalates when the file is huge (100's of MB). Do find-file only if the searched file is not yet opened in any buffer.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
counsel.el (counsel-grep-action): If a file is already open in
a buffer, get that buffer's handle using get-file-buffer. This
is to prevent the scenario where a file is already opened using
find-file-literally. In that case, if find-file is attempted for
the same file, user is nagged with question if they intended to
switch to opening the file normally from "literally". Situation
escalates when the file is huge (100's of MB).
Do find-file only if the searched file is not yet opened in any
buffer.