New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-org-goto--add-face): Keep text properties #1012

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
2 participants
@fabacino
Contributor

fabacino commented May 17, 2017

If counsel-org-goto-face-style was set to nil, the headlines were stripped of all their text properties. This caused text to appear which was intentionally hidden by org-mode e.g. the uri of a link.

The fixed function now just applies the default minibuffer face on top of the existing properties, which looks like the entries have not been styled at all but preserves the other properties.

counsel.el (counsel-org-goto--add-face): Keep text properties
If counsel-org-goto-face-style was set to nil, the headlines were
stripped of all their text properties. This caused text to appear
which was intentionally hidden by org-mode e.g. the uri of a link.

The fixed function now just applies the default minibuffer face on top
of the existing properties, which looks like the entries have not been
styled at all but preserves the other properties.

@abo-abo abo-abo merged commit 299b851 into abo-abo:master May 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Owner

abo-abo commented May 18, 2017

Thanks.

@fabacino fabacino deleted the fabacino:bugfix/counsel-org-goto-bad-links branch May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment