New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ivy-partial from dropping out of case-folding #1021

Merged
merged 1 commit into from May 20, 2017

Conversation

Projects
None yet
3 participants
@Georgiy-Tugai
Contributor

Georgiy-Tugai commented May 19, 2017

When ivy-case-fold-search is 'auto, the matched partial candidate
may contains uppercase letters, which disables case-folding in
subsequent completions and thus over-narrows the result set.

Prevent ivy-partial from dropping out of case-folding
When ivy-case-fold-search is AUTO, the matched partial candidate
may contains uppercase letters, which disables case-folding in
subsequent completions and thus over-narrows the result set.

@abo-abo abo-abo merged commit d933bc8 into abo-abo:master May 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Owner

abo-abo commented May 20, 2017

Thanks. Please look into getting an Emacs CA for more contributions, see README.

@cmm

This comment has been minimized.

cmm commented on ivy.el in d933bc8 May 20, 2017

new may be eq to t, in which case (downcase new) throws an error.
(you may notice how the cond below even has a case to handle this...)

@Georgiy-Tugai

This comment has been minimized.

Contributor

Georgiy-Tugai commented May 22, 2017

@cmm Thanks for catching that! 👍
@abo-abo Both of my contributions here were done on company time; I'll have to talk to legal about that.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented May 23, 2017

@Georgiy-Tugai, I only care about future contributions. There's a 15 line limit for contributions without a CA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment